It takes a long time to delete a file

[rija]

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

1. Go to https://gigadb.org/adminFile/admin
2. Click on the delete icon for a file
3. See a spinning wheel
4. Wait a long time for the file row to disappear and for the spinning wheel to stop

Expected behavior The file entry should be removed promptly

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context this behaviour seem to have appeared with the merge of PR #2017 that fixes #2015.

my intuition tells me it's related to Postgresql indexes and the database transaction that wraps the deletion of the associated entries from the file_attributes table and then of the row in the file table.

[alli83]

@rija it's something I noticed while fixing the problem. there is definitely some code that needs to be reworked. On this ticket, no substantial changes on the old code. Given that a new ticket should be assigned, I didn't fix it in this #2017 PR. the different for loop should be avoided because a a delete is triggered for each relation atm (n+1).

I have another PR with deleteAll executing a single SQL delete instead of the foreach.

[rija]

Fixed in PR #2043