curation log issues

[only1chunts]

related to #2044

The curation log is not behaving as expected, in addition to the spurious addition of Curator assigned (#2044) there are also additions of "Status changed to" when you click save after NOT making any status change.

The change that I made was to the dataset size value, which was NOT logged in the curation log as being changed.

Eventually we need to go over the actions to ensure all changes are logged and that things that are NOT changed are NOT logged. But that is basically the work in Milestone "I", so not urgent. For now, can we just stop it adding spurious entries when things are NOT changed.

User story

As a curator
I want changes I make not related to changing status to not add a "Status changed to" curation log entry So that I can trust the curation log reflects the change I make

Acceptance criteria

Given I am on the admin page for a dataset
When I edit a field (not the status) and save Then the changes are saved And a curation log entry saying "Changes made to the dataset's fields: \<changed fields>" is added

Given I am on the admin page for a dataset
When I change the dataset upload status to \<status> Then the changes are saved And a curation log entry saying "Status changed to \<status>" is added

Additional Info

Product Backlog Item Ready Checklist

• [ ] Business value is clearly articulated
• [ ] Item is understood enough by the IT team so it can make an informed decision as to whether it can complete this item
• [ ] Dependencies are identified and no external dependencies would block this item from being completed
• [ ] At the time of the scheduled sprint, the IT team has the appropriate composition to complete this item
• [ ] This item is estimated and small enough to comfortably be completed in one sprint
• [ ] Acceptance criteria are clear and testable
• [ ] Performance criteria, if any, are defined and testable
• [ ] The Scrum team understands how to demonstrate this item at the sprint review

Product Backlog Item Done Checklist

• [ ] Item(s) in increment pass all Acceptance Criteria
• [ ] Code is refactored to best practices and coding standards
• [ ] Documentation is updated as needed
• [ ] Data security has not been compromised (with particular reference to the personal information we hold in GigaDB)
• [ ] No deviation from the team technology stack and software architecture has been introduced
• [ ] The product is in a releasable state (i.e. the increment has not broken anything)

[rija]

I spotted a species name that needed to be italicised (102584). Did it, minted it, added a log. 4 other logs have been added - curator assigned (we know about that) and then 'status changed to'.