Hard coded dataset types in home page HTML E678

only1chunts commented 4 years ago

User story

As a site administrator I want the GigaDB.org homepage list of dataset types to include the same list of dataset types as we have in the curator admin pages So that the website is kept upto date with any changes we make to the list of dataset types in the admin pages

Acceptance criteria

Given a dataset type is in the admin pages When a user visits the gigadb.org home page Then they can see a link in the Dataset types section to that type

Given I update a dataset type name in the admin pages When a user visits the gigadb.org home page Then they see the updated dataset type in the dataset type section of that page.

Additional Info

Describe the functionality The home page contains a summary of the number of datasets of each particular dataset type. It appears it has been created using the textual names of the dataset types rather than actually looking in the database to find the names of the dataset types! This means that if we want to change the dataset type name (e.g. Proteomic to Proteomics) it crashes the GigaDB.org home page.

To Reproduce

Go to http://gigadb.org/adminDatasetType/admin change one of the dataset type names & save changes.
Goto http://gigadb.org
see a database error message

Expected behavior If the dataset name is changed in the admin pages the change should be reflected on the homepage (as well as each of the datasets using that dataset type).

Additional context It is expected that the number of different dataset types will grow, currently we have 21 is use in the database, only 20 of those are displayed on the home page. Presumably thats because the homepage HTML code needs to be changed whenever a new dataset type is added and it wasn't! The home page should be using all dataset types from the database and automatically update when a new dataset type is added. NB - the count of datasets using each particular type shown on the home page should only be those datasets set to PUBLIC status. The count in the admin pages should include all statuses

Product Backlog Item Ready Checklist

[ ] Business value is clearly articulated
[ ] Item is understood enough by the IT team so it can make an informed decision as to whether it can complete this item
[ ] Dependencies are identified and no external dependencies would block this item from being completed
[ ] At the time of the scheduled sprint, the IT team has the appropriate composition to complete this item
[ ] This item is estimated and small enough to comfortably be completed in one sprint
[ ] Acceptance criteria are clear and testable
[ ] Performance criteria, if any, are defined and testable
[ ] The Scrum team understands how to demonstrate this item at the sprint review

Product Backlog Item Done Checklist

[ ] Code is complete
[ ] Automated tests related to the changes are implemented and passing
[ ] All automated test suites are passing locally
[ ] Code is refactored to best practices and coding standards
[ ] Documentation is updated as needed
[ ] A Pull Request has been created and review requested
[ ] Pull Request is reviewed and approved
[ ] The item has been merged to the develop branch
[ ] All automated test suites are passing on continuous Integration pipeline and item is ready to release

This Story is part of Epic #678

only1chunts commented 3 years ago

probably part of same Epic as #288

rija commented 1 year ago

Use this spreadsheet as source for the dataset type: https://docs.google.com/spreadsheets/d/1shH-QK-UT9HD88ysWFHVq5xUenxAmcbg/edit?usp=sharing&ouid=113349048176711233698&rtpof=true&sd=true

only1chunts commented 1 year ago

I think this can be decoupled from Epic #678 as its about the display on the home page not the use of the SRAO in the database. The only point of consideration related to the SRAO is the fact that there will be more dataset types to be displayed in the future.

gigascience / gigadb-website