search

gigebyte / cookies

Automatically exported from code.google.com/p/cookies
0 stars 0 forks source link

hoursToLive option is ignored if negative--not consistent with delete concepts #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Line 40 checks that hoursToLive option is greater than 0 before attempting
to use.  This causes negative values to be ignored--but the generally
accept way to delete cookies via JS is to set the expiration of a cookie
into the past.

Given the new concepts in use to resolve options (since v2.0.1), this
option should only be ignored if not numeric, or if equal to 0.

Fix is simple and enroute.

Original issue reported on code.google.com by auldrid...@gmail.com on 21 Feb 2009 at 9:44

GoogleCodeExporter commented 9 years ago 
Fixed in r19

Original comment by auldrid...@gmail.com on 21 Feb 2009 at 10:10

GoogleCodeExporter commented 9 years ago 
Issue 7 has been merged into this issue.

Original comment by auldrid...@gmail.com on 25 Feb 2009 at 2:15

GoogleCodeExporter commented 9 years ago

Original comment by auldrid...@gmail.com on 25 Feb 2009 at 2:21