giggls / mapnik-german-l10n

OSM map l10n functions
Other
28 stars 40 forks source link

`make deb` changes a file which is under version control. #55

Open amandasaurus opened 4 years ago

amandasaurus commented 4 years ago

If you run make deb on a freshly checked out version (f17d7dc) on Ubuntu Linux 18.04, then do git diff, you get:

diff --git debian/control debian/control
index 281c978..ef4103d 100644
--- debian/control
+++ debian/control
@@ -8,13 +8,13 @@ Build-Depends: debhelper (>= 8.0.0), libicu-dev,
  curl, libkakasi2-dev, libutf8proc-dev, pandoc
 Standards-Version: 3.9.2

-Package: postgresql-11-osml10n
+Package: postgresql-10-osml10n
 Architecture: any
 # "postgis" is used as some kind of meta package here, because it
 # contains all dependencies for whatever version of PostGIS is available
 # on the Debian or Ubuntu intallation this code is going to get built
-Depends: ${shlibs:Depends}, ${misc:Depends}, postgresql-11, icu-devtools
-Recommends: postgresql-plpython3-11, python3-matplotlib, python3-pip, postgis
+Depends: ${shlibs:Depends}, ${misc:Depends}, postgresql-10, icu-devtools
+Recommends: postgresql-plpython3-10, python3-matplotlib, python3-pip, postgis
 Description: l10n package for generation of OSM based maps from PostGIS
  localisation package  for generation of OSM based maps from PostGIS.
  This is currently used in german mapnik style but can be used in a

i.e. make deb changes files which are checked into git. This doesn't seem right. Same thing happened on an Ubuntu Linux 20.04 server.

giggls commented 4 years ago

Unfortunately I have no idea for a simple solution to this issue.

If I remove the file from the repository I have to somehow create it before calling dpkg-buildpackage because dpkg-buildpackage simply does not work if this file does not exist.

While I could do this in the Makefile I would not like to have a repoitory where calling dpkg-buildpackage does not work.

I wonder how this is done in official Debian repositories, because I found this hack with re-creating debian/control during package build in a package for another PostgreSQL extension.