add array type hint to `PhoneNumber::__unserialize`

giggsey / libphonenumber-for-php

PHP version of Google's phone number handling library

https://giggsey.com/libphonenumber/

Apache License 2.0

4.76k stars 468 forks source link

add array type hint to `PhoneNumber::__unserialize` #637

Closed IcarusSosie closed 4 months ago

IcarusSosie commented 4 months ago

fixes #636

IcarusSosie commented 4 months ago

Just ran the tests locally, seems to work fine on php 8.3.7. Should I run them on other versions ?

giggsey commented 4 months ago

So apparently this works in PHP 5.3. I had completely forgotten you could use type hints back then.

I'll review closer within a few days, but will likely merge.

Thanks

IcarusSosie commented 4 months ago

Oh, just saw your comment on the PR. That's awesome, thanks !

giggsey commented 4 months ago

Thanks for the fix.

The next version will be released once Google release their next version (to maintain version number compatibility). That'll likely be within two weeks.