gigili / good-food-tracker-api

Good food tracker - API
MIT License
6 stars 11 forks source link

Enhance readme setup steps #219

Closed abilogos closed 3 years ago

abilogos commented 3 years ago

Hi Gigili, Thanks for Starting this project, When I was going to setup the project, I have encounter some Issues which took me time to find out. meanwhile I have updated the README.md & the migration.example.conf in order to other developers fast project setup

after that I have faced with a bug which was related to the index.php . I have searched and found out that __DIR__ returns the path without trailing slash . after I add the / to the path. it has been worked.

Since the php is running from the docker container, it should be platform independent and everybody should have faced this issue. but I don't why it hasn't been discovered up to know.

if this issue is just with my platform, just let me know.

gigili commented 3 years ago

Hey, thank you for your contribution, that issue with index.php was a bug that I introduced by an accident, but was fixed recently.

The changes look nice and structured.

@all-contributors please add @abilogos for documentation

allcontributors[bot] commented 3 years ago

@gigili

I've put up a pull request to add @abilogos! :tada: