giginet / danger-xcprofiler

🚫 danger plugin for asserting Swift compilation time
MIT License
50 stars 4 forks source link

Add option to insatiate profiler using xcactivitylog path #11

Closed aChase55 closed 3 years ago

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.3%) to 97.222% when pulling 6397d9bd10fef2301140cacd33024322a8ff5483 on aChase55:master into a40f954cc9d348db04ee51ff12bf1d43cf3bf89a on giginet:master.

pschneider commented 3 years ago

@giginet Hey! Is this something feasible to add? We use a custom build directory (within the repo path ./build/) and xcprofiler seems to not work without passing a custom path for the activity log:

bundle exec xcprofiler --derived-data-path build/Logs/Build/*.xcactivitylog
giginet commented 3 years ago

Sorry. I missed this PR for over 1 year... 🙇

I'll check this tomorrow. Sorry for your patience.

giginet commented 3 years ago

@aChase55 @pschneider Sorry for such a long time 🙏 I just released 0.5.0

aChase55 commented 2 years ago

Its okay! I forgot I had opened it! Thanks for merging 👍