giginet / xcprofiler

:chart_with_upwards_trend: CLI to profile compilation time of Swift project
MIT License
332 stars 13 forks source link

Add --threshold option #2

Closed jpmartha closed 7 years ago

jpmartha commented 7 years ago

Before the review:

Add --lower-limit option.

Usage:

$ xcprofiler MyApp --lower-limit 500

After the review:

Add --threshold option.

Usage:

$ xcprofiler MyApp --threshold 500

Result:

+--------------------------------+------+-----------------------------------+----------+
| File                           | Line | Method name                       | Time(ms) |
+--------------------------------+------+-----------------------------------+----------+
| Sssssssssssss.swift            | 47   | @objc override func viewDidLoad() | 4072.2   |
| Rrrrrrrrrrrrrrrrrrrrrrrr.swift | 78   | @objc override func viewDidLoad() | 1064.4   |
| Tttttttt.swift                 | 83   | @objc override func viewDidLoad() | 651.4    |
+--------------------------------+------+-----------------------------------+----------+
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.636% when pulling 1656c3fa4a295354638c8ba602b5aba470b5d9b8 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 89.636% when pulling 1656c3fa4a295354638c8ba602b5aba470b5d9b8 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 89.779% when pulling b743ea32777cdbbb8eeb53a98f7cf1449039ca5f on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 89.779% when pulling b743ea32777cdbbb8eeb53a98f7cf1449039ca5f on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.186% when pulling 409b7f75704e969fcf3cf529c3a586b65cffb406 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.186% when pulling 409b7f75704e969fcf3cf529c3a586b65cffb406 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.186% when pulling 409b7f75704e969fcf3cf529c3a586b65cffb406 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

jpmartha commented 7 years ago

--lower-limit is similar to --limit, so it might confuse us. Please feel free to direct me to change the option and description.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling 242b2b76b5bb7b38330982878c8f84b154af4c0c on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling 242b2b76b5bb7b38330982878c8f84b154af4c0c on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

jpmartha commented 7 years ago

@giginet Happy new year!

Thank you for the review. I revised them. Could you review again?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling c6222f51577971f60ecab5658cf771cf6684246d on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling c6222f51577971f60ecab5658cf771cf6684246d on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling c6222f51577971f60ecab5658cf771cf6684246d on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling c6222f51577971f60ecab5658cf771cf6684246d on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling 355e8f155466c89033a63f045861438cd08e6e46 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling 3113606bd91d0bdb93f245a751e59cf90d427e16 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling 3113606bd91d0bdb93f245a751e59cf90d427e16 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

jpmartha commented 7 years ago

@giginet

Sorry, I omitted to revise 2 points, and fixed them. Could you review again?

giginet commented 7 years ago

@jpmartha Thank you.

I pointed trivial syntax issue. After you fix it, I'll merge and release a newer version.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling b0a1acb81417395949f3dba65ae87246a8ee0153 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.4%) to 90.212% when pulling b0a1acb81417395949f3dba65ae87246a8ee0153 on jpmartha:add-lower-limit-option into 0e8df8fb5c0d6f92177185383ef0d4bd80726f35 on giginet:master.

jpmartha commented 7 years ago

@giginet

Fixed it! Thanks for your review in detail.

giginet commented 7 years ago

I released as 0.2.2 and it is available on RubyGems. Thank you!