search

giginet / xcprofiler

:chart_with_upwards_trend: CLI to profile compilation time of Swift project
MIT License
332 stars 13 forks source link

Fix filter_executions order #3

Closed jpmartha closed 7 years ago

jpmartha commented 7 years ago

Fixed bug related to #2.

Before the change:

$ xcprofiler MyApp -l 10 --threshold 300 -o file
  1. Sort data
  2. Extract limited count
  3. Delete data below threshold

=> Extract incorrect count due to 3.

After the change:

$ xcprofiler MyApp -l 10 --threshold 300 -o file
  1. Sort data
  2. Delete data below threshold
  3. Extract limited count

=> Extract limited count.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.212% when pulling 941aab877c8a85d726e43a7d2b8d3bcdb1aed450 on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 90.212% when pulling 941aab877c8a85d726e43a7d2b8d3bcdb1aed450 on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

giginet commented 7 years ago

You are right. I couldn't realize.

Could you add specs to test this situation? Testing whether when passing all parameters then it can behave correctly.

jpmartha commented 7 years ago

@giginet I'll give it a try.

jpmartha commented 7 years ago

@giginet I'll add specs to test with multi_options. How about them?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.3%) to 91.553% when pulling b97ae0f53514ceec80212e0c21ad4dab5c9d2c4f on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.3%) to 91.553% when pulling 1c74456a65fecdd358475588a6fe11166d0d188a on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.3%) to 91.553% when pulling 1c74456a65fecdd358475588a6fe11166d0d188a on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.3%) to 91.553% when pulling 1c74456a65fecdd358475588a6fe11166d0d188a on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+1.3%) to 91.553% when pulling 1c74456a65fecdd358475588a6fe11166d0d188a on jpmartha:fix-filter-executions into fa9b09e0998f3f5852889eed6727a2515d053fd4 on giginet:master.

jpmartha commented 7 years ago

Failed tests with show_invalid_locations on Ruby 2.3.1, so I'll check it later.🤔

giginet commented 7 years ago

I ran specs on the local machine then they passed. 🤔

giginet commented 7 years ago

I found the cause.

In the case of file order, the sort order of results which are same files are ambagious. So, I defined sort orders explicitly.

jpmartha commented 7 years ago

@giginet LGTM 👍 Thanks :D

giginet commented 7 years ago

Thank you for coding such a lot of specs. LGTM. I'll merge and release it.

jpmartha commented 7 years ago

@giginet Thanks for your review! 🎉