search

gigitux / youpforwhatsapp

A simple wrapper written in rust and gtk-rs for whatsapp web
MIT License
84 stars 9 forks source link

Fix rust build scripts #44

Closed kaimast closed 3 years ago

kaimast commented 3 years ago

I noticed some three minor issues with the build scripts.

First, cargo.sh uses [[ even though that is a bash command. I guess you have linked /bin/sh to /bin/bash on your machine? It's not the cases for me and, as a result, it always builds in debug mode.

Second, I added all source files to src/meson.build so changes in the rust code actually cause a re-build.

Third, I removed the --offline-flag rom the release build. That causes problems when you build in release mode on a fresh checkout.

gigitux commented 3 years ago

Merged.

Thanks a lot for this pull request! :raised_hands: