search

gigitux / youpforwhatsapp

A simple wrapper written in rust and gtk-rs for whatsapp web
MIT License
85 stars 9 forks source link

Add linter to CI #50

Closed kaimast closed 3 years ago

kaimast commented 3 years ago

This adds the cargo clippy linter to the github workflow. I also fixed all warnings created by clippy.

One comment though: You should consider adding logging support to youp. Seems like there is a bunch of places where return values are not checked. Youp should at least log a warning when things go wrong.

gigitux commented 3 years ago

Thanks for this PR!

Youp should at least log a warning when things go wrong.

Mmm, you are actually right! I have to check if there is any feature of the gtk / glib for logging or I have to manage it manually