search

gigocabrera / moneyleash

Personal Expense App Ionic-AngularJS-Firebase
29 stars 21 forks source link

Unable to join house #3

Open bandojulio opened 8 years ago

bandojulio commented 8 years ago

after creating a house with an new user, I tried to join it with another user but the app do nothing.

gigocabrera commented 8 years ago

This is due to the security rules implemented for the app (see this gist)

I am doing a full rewrite of the app using ionic2/angular2 that should solve a plethora of bugs in this version and improve performance considerably. Take a look and follow if you want (see MoneyLeash2)

bandojulio commented 8 years ago

ok, i will take a deeper look in the rules.

Also, it should be nice to allow users to share accounts instead of houses, what you think about this?

I will see moneyleash2. Thanks!

gigocabrera commented 8 years ago

That's the whole idea for a "House" (can also be called "Group"). The people in the House/Group share the accounts they create. For example: 1) checking husband 2) checking wife 3) checking both The husband may have a checking account for himself, just like the wife. But they have one that they share. Since the wife is part of the House, she can see all the accounts. The account flagged as "both" will show transactions done by each. Did you have a different approach? I would love to hear it if you do.

bandojulio commented 8 years ago

Yes, I have a different approach for that. What if I want to have a shared account with my brother that belongs to another house/group? In your definition above, we will not be able to share it. I am thinking in a solution where I can invite to one account that I have created. Then, we will have an account with one owner and multiple members. In this approach the concept of group is associate with account, so user will be able to be in multiple groups.

gigocabrera commented 8 years ago

Make sense and your approach will provide better flexibility in sharing accounts. I like it! I will definitely implement this approach for MoneyLeash2 and change the security rules as needed. Since Angular2 and Ionic2 are still on beta it's hard to formally commit changes to MoneyLeash2 as it is a moving target. But I have been able to make good progress with what is available at the moment. I will commit the latest changes this coming week.

bandojulio commented 8 years ago

I will wait for your commit to see the Ionic2 code. I think it is completely different from Ionic and as you said Angular2 and Ionic2 are still on beta. I hope to help you with your Money Leash in the future since it is a great source to understand how Ionic and Firebase works together.