Customization of the template content closes #3

giis-uniovi / retorch

RETORCH: Resource-aware End-to-End Test Orchestration

Apache License 2.0

1 stars 1 forks source link

Customization of the template content closes #3 #4

Closed augustocristian closed 1 year ago

augustocristian commented 1 year ago

Removed modules not used
Changed module-project names to retorch and retorch-annotations
Namespace renamed to giis.retorch.annotations
Test case modifed to pass (uses one of the modules removed)
Some little spell mistakes corrected.
Added .settings to the module retorch-annotations (ignored originally by the gitignore)
SonarQube configurations performed
Customization of the master and retorch-annotations pom.xml files
First version of the README.md with basic information about the annotations, contributing, citation,contact etc.

javiertuya commented 1 year ago

@augustocristian Just a tip: you don't need to always push every internal commit that you do because each push starts all workflows and sonar (if configured)

augustocristian commented 1 year ago

Dear @javiertuya Now everything seems to be working correctly. I made changes to the URL artifacts in the pom.xml. Initially, I thought this information/parametrization was included in the Actions file. However, after reviewing it, I realized it needed to be modified in the pom.xml instead.

augustocristian commented 1 year ago

Personalized the README, following the sections of td-rules plus some extra (contact and acks) as well as the the first draft of the annotations

javiertuya commented 1 year ago

@augustocristian Remember that the comment that originated this was *Customize this description: a simple statement to say what is retorch, the annotations. Include a note to explain that annotations are the only available now, but in a near future, other retorch componentes will be available.".

You can keep the details, but please, include the note referred to in the second part

augustocristian commented 1 year ago

I apologize for the misunderstanding. I understood that this minor personalization was intended only in the pom.xml file (with the note that not all components are available at the moment), so when this morning I realized the change resquest in the readme, I thought it was to include all (at least a preliminary version)

javiertuya commented 1 year ago

@augustocristian Is this for review? there are 2 unresolved conversations. No PR can be merged if any conversation is unresolved.

augustocristian commented 1 year ago

I have accepted all the requested changes and uploaded them to the repository. Why is one change still appearing as needing acceptance? @javiertuya I only found this: