gijsdev / ublock-hide-yt-shorts

uBlock Origin filter list to hide YouTube Shorts
MIT License
1.15k stars 63 forks source link

Filter rewrite #10

Closed ghost closed 5 months ago

ghost commented 5 months ago

Not relevant idea was bs...

gijsdev commented 5 months ago

My main issue with your last PR was the removal of legitmate filters and that it was based on a dead branch (the latter was my fault).

I'm also against shaking up the entire filter list at this point in time since it works fine and doesn't contain a lot dead filters.

ghost commented 5 months ago

Yes the regex filter is too verbose i agree. (Adding the # could be an idea) Also learning too read would be a good idea on my side haha. The previous PR removed the the ytd-mini-guide-entry-renderer filter and did not contain a filter that would remove the element itself as i thought. Also the list does not contain as many outdated elements as i intially anticipated so that was time wasted i guess. I altered the edit date again because it was a full rewrite but i now get that you really only want to use it for the version bumps.