changed method to methods and added args - Githubissues

gijswobben / pymed

PyMed is a Python library that provides access to PubMed.

MIT License

191 stars 111 forks source link

changed method to methods and added args #13

Closed esteininger closed 5 years ago

esteininger commented 5 years ago

All Submissions:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

[ ] Does your submission pass tests (if applicable)?
[ ] Have you lint your code locally prior to submission (use flake8)?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?

gijswobben commented 5 years ago

Hi Ethan, Thanks for contributing! I hope you don't mind but I've rewritten the code of your pull requests a bit. I saw, for example, that you use .find instead of .findall, which means you're missing part of the abstracts. I also had some request for other fields so I added them in a single pull request. Kind regards, Gijs