search

gijzelaerr / python-snap7

A Python wrapper for the snap7 PLC communication library
http://python-snap7.readthedocs.org/
MIT License
643 stars 245 forks source link

Add byte type parsing to DB_Row API + set parsing case insensitive #313

Closed LoicGRENON closed 2 years ago

LoicGRENON commented 2 years ago

I added the BYTE type to the parsing to DB_Row API to avoid ValueError exception when parsing a specification with BYTE type value. I also set the string value to upper case in order to do a case insensitive search for the type of the value when parsing the specification (e.g. : BYTE, Byte, byte, etc ... are all acceptable).

gijzelaerr commented 2 years ago

thanks! The pycodestyle check fails though, can you fix that also?

LoicGRENON commented 2 years ago

thanks! The pycodestyle check fails though, can you fix that also?

Yeah, I see it failed. It's because I did the commit using the github web-editor and it automatically add indentation on each new lines ... Unfortunately, I deleted the branch from my repo so I can't commit on it anymore.

Not sure what I could do. Should I do another PR with corrected pycodestyle error ? Can you accept this PR and then remove the indentation on the new line ?

swamper123 commented 2 years ago

I would say close this PR in that case, pull the master, create new branch, copy&pasta these view lines/fix them. This would be the cleanest way. :)