search

gilbarbara / codeclimate-stylelint

A Code Climate engine for the mighty, modern CSS linter
24 stars 18 forks source link

Add support for stylelint-config-css-modules #16

Closed killthrush closed 6 years ago

killthrush commented 6 years ago

Hi! Our team has an avid interest in using CSS Modules with CodeClimate. We've had a lot of success writing application code with them and have recently configured stylelint to help us keep things clean. Our config includes the use of the stylelint-config-css-modules shared ruleset, which is not included in the docker image.

I'm going to see if I can put together a quick PR with some tests to implement this change. Hopefully we can get a new image soon.

Thanks!

gilbarbara commented 6 years ago

Great, I was thinking about adding it

killthrush commented 6 years ago

@gilbarbara Addressed in https://github.com/gilbarbara/codeclimate-stylelint/pull/17

killthrush commented 6 years ago

@gilbarbara - just a friendly bump... do you have the bandwidth to look at this PR?

gilbarbara commented 6 years ago

Sorry! I'll do it tonight! 😄

gilbarbara commented 6 years ago

hey

I've merged #17 but still have some updates to do before publishing a new version to the codeclimate docker image. 80% done!

killthrush commented 6 years ago

Thanks @gilbarbara - your master branch looks good on my end. Feel free to close this issue when you release!

gilbarbara commented 6 years ago

Released as 1.7.0 I've already sent notice to codeclimate about the release and it should be on their site soon.

Thanks @killthrush