search

gilbarbara / codeclimate-stylelint

A Code Climate engine for the mighty, modern CSS linter
24 stars 18 forks source link

Add support for styled components #26

Closed dpuscher closed 5 years ago

dpuscher commented 5 years ago

styled-components is a popular css-in-js library and stylelint is the tool of choice to do linting of the css parts.

This pull request adds linting support for this framework. For details see #25

gilbarbara commented 5 years ago

Hey @maxjacobson Yeah, I think is a great idea to move the repo to codeclimate-community. I haven't been using it anymore and it would be great to have other maintainers.

I'll add tests for this and a coupler other PRs and update dependencies ASAP.

maxjacobson commented 5 years ago

Sounds great. Feel free to transfer following these steps: https://help.github.com/en/articles/transferring-a-repository

efueger commented 5 years ago

Hi @gilbarbara - thanks for your help!

gilbarbara commented 5 years ago

@maxjacobson, @efueger Hey! I tried to transfer the repo today but got an error: You don’t have the permission to create repositories on codeclimate-community

maxjacobson commented 5 years ago

@gilbarbara ah, I see. Well.. Hm. Perhaps if you give Emily or myself admin access over gilbarbara/codeclimate-stylelint, we'll be able to transfer it, since we do have permission to create repositories in that organization.

efueger commented 5 years ago

@gilbarbara - Can you give @maxjacobson or me admin access for this repo? Thanks 👌

gilbarbara commented 5 years ago

@efueger I will hold off the transfer for now. codeclimate-community organization isn't really a community since there aren't any public members.

maxjacobson commented 5 years ago

Hi Gil - that org is owned by Code Climate, and our staff are all members, although most of us have left the membership as private, which I suspect is the default. I just toggled my membership over to public. The idea for that organization (I think) is to have a home for plugins which have been developed in collaboration with the broader community of plugin makers. It's totally fine to keep this plugin here under your user if you prefer. If you'd like help with maintenance, perhaps you could still add some Code Climate staff so we can help out with merging PRs and closing issues, but no presh.

In the meantime, I see that you've merged several things to master, so I'm going to go ahead and push those changes out to codeclimate.com

gilbarbara commented 5 years ago

@maxjacobson Cool, it's a big upgrade! 👍

davehenton commented 5 years ago

Hey @gilbarbara, Dave here with Code Climate. After we pushed out these most recent changes, we encountered a few newly-erroring builds.

Here's the error our users are seeing:

•• Timing: .engineConfig: 0.444s
Error: parser.parse is not a function

We've now reverted these changes while we sort out the cause of the errors. Do you have any thoughts here? Let me know (or @maxjacobson ) know of any other info you might need.