gilbarbara / codeclimate-stylelint

A Code Climate engine for the mighty, modern CSS linter
24 stars 18 forks source link

does codeclimate-stylelint support configs in package.json #38

Closed efueger closed 4 years ago

efueger commented 4 years ago

@gilbarbara - Emily here from Code Climate Support 👋

A customer wrote in reporting they recently migrated over from using stylelint's .stylelintrc file to a "stylelint" property in package.json and now it seems that stylelint is broken.


Let me know if I can provide any additional details. Thanks!

andersevenrud commented 4 years ago

Also note that I'm using "extends" with a package from npm (containing stylelint rule set).

andersevenrud commented 4 years ago

I also noted the following on another repo I maintain:

  1. A user submitted this pull request and his seems to be OK.
  2. I created this pull request and gets the same error.

Both of those branch HEADs are after I changed to the package.json layout + stylelint rule package.

gilbarbara commented 4 years ago

@efueger @andersevenrud I think the problem isn't about the config being in the package.json but with CodeClimate since they don't install packages in their infra. If you try to load a package that this engine doesn't support, like @osjs/stylelint-config it will break,

andersevenrud commented 4 years ago

@gilbarbara Does this apply to the standard stylelint extensions as well ?

Edit: Sorry, I totally read that wrong. I now see the list of supported ones.

I'll have to look into alternatives.

andersevenrud commented 4 years ago

@efueger You can close this issue. As mentioned in my previous [edited] comment, I'll find an alternate way of running a stylelint check.