Request: update Stylelint version

gilbarbara / codeclimate-stylelint

A Code Climate engine for the mighty, modern CSS linter

24 stars 18 forks source link

Request: update Stylelint version #40

Closed efueger closed 4 years ago

efueger commented 4 years ago

Emily here from Code Climate Support.

We've had an oss customer hitting unknown rule errors like "Error: Undefined rule scss/at-each-key-value-single-line"
see more builds here: https://codeclimate.com/github/Dark-Heresy/front-end/builds

With other plugins, this typically is a versioning issue.

@gilbarbara - what do you think? Do you think updating the plugin would help with this?

Let me know if I can provide additional details. Happy to help.

Thanks!

miktirr commented 4 years ago

Upgrading to the latest stylelint version (13.7.x) and configuration practices seems to break this engine.

This is because stylelint has deprecated *-blacklist, *-requirelist and *-whitelist rules in favor of the new *-disallowed-list, *-required-list and *-allowed-list ones.

If one migrates to the new rule names, this engine fails and throws error related to the new naming conventions:

efueger commented 4 years ago

Thanks for the report @miktirr .

can you send me a link to the error page above? or to your repo?

Cheers, Emily

miktirr commented 4 years ago

Sure, @efueger! The repo itself is not public but you should see the build error here: https://codeclimate.com/repos/5da99cdb529bf4014e0092bb/builds/2165 I’m also happy to provide additional details of our setup, if it helps.

gilbarbara commented 4 years ago

hey @efueger You need to update the engine. It is running a really old version.

Anyway, it has been updated in 2.3.0 (engine 13.7.2)