Closed fede-moya closed 3 years ago
I can't accept merge commits, besides the conflict. Please rebase your branch properly.
Also, since this PR adds new dependencies, please add tests to cover the changes.
I can't accept merge commits, besides the conflict. Please rebase your branch properly.
Also, since this PR adds new dependencies, please add tests to cover the changes.
@gilbarbara Sorry for the mess, and thank you for the indications. Updated.
@gilbarbara 🙌🏼
Hi @gilbarbara - thanks for your help with this! LMK if you need anything else from Code Climate's side.
@gilbarbara - checking to see if you can merge this. Thanks in advance for the help!
This is the second attempt for fixing an issue related the use of relative paths on a given stylelint configuration file.
On the first attempt I tried to point stylelint's base dir to
/code
where the source code to analyze is. This was actually a bad diagnose, it only worked because in the users's source code there was anode_modules
folder containing the necessary stylelint's packages.Reading stylelint's api docs more carefully I found the following:
https://stylelint.io/user-guide/configure#ignorefiles
So, if you set
configBaseDir
then that dir will became the root for relative paths indicated in theignoreFiles
config. If we want to set theconfigBaseDir
to indicate stylelint from where to extract the necessary packages then we will need to modify user'signoreFiles
configuration to use absolute paths.