search

gilbarbara / codeclimate-stylelint

A Code Climate engine for the mighty, modern CSS linter
24 stars 18 forks source link

Add stylelint-config-idiomatic-order to package.json and README #51

Open azzcatdesign opened 3 years ago

gilbarbara commented 3 years ago

hey @azzcatdesign

You need to install the new dependency with npm and commit the package-lock.json. Also, can you please add tests?

thanks

azzcatdesign commented 3 years ago

Ah, sorry! Was following earlier example and didn't realize.

Looks like I'm in over my head. I can install stylelint-config-idiomatic-order as a dev dependency via npm, but that's not what you're looking for here. I have no idea how to tackle an installation via npm similar to SUIT CSS:

"stylelint-config-suitcss": {
      "version": "15.0.0",
      "resolved": "https://registry.npmjs.org/stylelint-config-suitcss/-/stylelint-config-suitcss-15.0.0.tgz",
      "integrity": "sha512-MVkhy8oPuFt1I2+TKqdKxukstNQ5oQDHtztBVNVL6uS2ZwRGE2hqq+Hc1Q5bXZswH6ApoQfdbjCmS8N3avwsBg==",
      "requires": {
        "stylelint-order": "^4.1.0",
        "stylelint-suitcss": "^3.0.0"
      }
    },

Nor do I know how to add tests.

Apologies.

gilbarbara commented 3 years ago

It's not so simple, you'll need to set up the docker environment to run codeclimate locally and analyze a file that uses the new dependency to make sure it is working...

If you enable "Allow edits from maintainers" in this PR, I can add the test later.

azzcatdesign commented 3 years ago

Edits enabled. Setting up a Docker environment on my own is not in my wheelhouse.

Thanks.

nitaigao commented 3 years ago

Any update?