search

gilbarbara / react-floater

Advanced tooltips for React
https://codesandbox.io/s/github/gilbarbara/react-floater/tree/main/demo
MIT License
213 stars 37 forks source link

Body border radius #50

Closed marcindabrowski closed 5 years ago

marcindabrowski commented 5 years ago

Fix for issue when the arrow is clashing with the body border-radius. There where two ways of fixing it - provide own modifier function for the arrow, or set margin for the arrow. I've chosen to set margin of the arrow - because in arrow modifier in popper (https://github.com/FezVrasta/popper.js/blob/master/packages/popper/src/modifiers/arrow.js) arrowElementSize includes margins.

marcindabrowski commented 5 years ago

I've updated all changes.

marcindabrowski commented 5 years ago

Thanks for approving pull request. Please also consider adding .gitattributes file.