Follow `open` state in controlled mode

gilbarbara / react-floater

Advanced tooltips for React

MIT License

220 stars 37 forks source link

Closed deevus closed 5 years ago

deevus commented 5 years ago

Side note: I couldn't get the tests to pass in my development environment and I didn't see any notes on how to configure it in the README.

gilbarbara commented 5 years ago

hey,

How to configure the tests? I'm not sure I understand what you meant.

deevus commented 5 years ago

Nevermind. I installed packages using yarn out of habit. Once I nuked node_modules and installed using npm install the tests worked fine.

deevus commented 5 years ago

Apparently I didn't save the codesandbox changes. Sorry about that.

deevus commented 5 years ago

@gilbarbara What do you need from me to merge this?

gilbarbara commented 5 years ago

@deevus Patience :)

deevus commented 5 years ago

Just making sure you haven't forgotten about this.