search

gilbarbara / react-floater

Advanced tooltips for React
https://codesandbox.io/s/github/gilbarbara/react-floater/tree/main/demo
MIT License
220 stars 37 forks source link

Arrow is misplace in IE 11 #63

Closed jucallej closed 4 years ago

jucallej commented 4 years ago

🐛 Bug Report

The left arrow is misplaced on IE 11

To Reproduce

Run the demo app https://github.com/gilbarbara/react-floater-demo on IE 11 and see that the left arrow is misplaced

Not_working_VirtualBox_IE11 - Win7_22_11_2019_11_14_44

Expected behavior

The arrow should not be misplaced.

jucallej commented 4 years ago

This is releated to https://github.com/gilbarbara/react-joyride/issues/517. I'm happy to look into making a PR for this 😀

gilbarbara commented 4 years ago

@jucallej I'm thinking of dropping support for IE. I can't see a way to support it without hacks and that's not something worth the trouble.

jucallej commented 4 years ago

@gilbarbara Just saw the comment. I understand whatever you decide 😀. In this case it's a css change (https://github.com/jucallej/react-floater/commit/fab103600cecafe14ceb4623dde7bf5e0d1af1a5). Everything else seems to work properly on IE 11 😁 (in my case I need to support it on my company and is afecting https://github.com/gilbarbara/react-joyride/issues/517 otherwise that ticket can not be cleanly solved). Should I open the PR for this? Your choice 😉

jucallej commented 4 years ago

Hey @gilbarbara ! What are your thoughts on this? Sorry for chasing you 😀

gilbarbara commented 4 years ago

@jucallej Sure, it's a simple fix.