Problems with chrome dark mode - Githubissues

gilbarbara / react-joyride

Create guided tours in your apps

https://react-joyride.com/

MIT License

6.62k stars 519 forks source link

Problems with chrome dark mode #1015

Closed devcer closed 3 months ago

devcer commented 3 months ago

🐛 Bug Report

The arrow color is not aligning with the dark mode.

To Reproduce

Steps to reproduce the behavior:

Open chrome://flags in chrome browser
Enable Auto Dark Mode for Web Contents and relaunch your browser
Open react-joyride website https://react-joyride.com/
Click on Start
On Step 2 you will see the arrow of the popover in white color

Expected behavior

The arrow should have been in dark color along with the popover

Link to repl or repo (highly encouraged)

Please provide a https://codesandbox.io/ demo or similar.

Issues without a reproduction link are likely to stall.

You can try this on official website. https://react-joyride.com/

Run `npx envinfo --system --binaries --npmPackages react-joyride`

Paste the results here:

gilbarbara commented 3 months ago

Hey @devcer I would say it's an issue with their override. Maybe they should consider SVG elements as well. I don't know how they are doing since the tooltip style still uses a white background. Since the colors are customizable, I don't want to hardcode a selector for this.