search

gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.88k stars 529 forks source link

Update @types/react-joyride package for the new version #379

Closed prawn-cake closed 5 years ago

prawn-cake commented 6 years ago

Expected behavior

Current version of the @types/react-joyride is 1.10.2 which doesn't match the properties of the latest version of the library.

Actual behavior

Spits out properties errors like Property X does not exist...

Steps to reproduce the problem

Run Joyride with typescript

React version

16.3.2 + typescript 2.8.3

React-Joyride version

2.0.0-11

Error stack

Example: TS2339: Property 'continuous' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Joyride> & Readonly<{ children?: ReactNode; }> & R...'.

tibetsprague commented 6 years ago

Any progress on this?

gilbarbara commented 6 years ago

This is not published by this package.

prawn-cake commented 6 years ago

Hi @gilbarbara Can you point out or help with which package / repo / team should this be addressed?

refactornator commented 6 years ago

@prawn-cake I resolved this by uninstalling @types/react-joyride and creating a custom type declaration in @types/react-joyride/index.d.ts here's a gist.

prawn-cake commented 6 years ago

Thanks @wlindner. It would be nice to have official solution though to avoid too many customisations.

@gilbarbara can you take a look at @wlindner solution and may be push it forward if it's sufficient?

gilbarbara commented 6 years ago

@prawn-cake It doesn't look right. I don't expose any methods in V2

gilbarbara commented 6 years ago

I'll try to add an official package before the final release. If somebody wants to help, that would be great.

prawn-cake commented 6 years ago

@gilbarbara I can help. What do you exactly want me to help with? To write type definitions for the public interface of the library? Do you have any preferences of the contribution process?

kdy1 commented 6 years ago

I've made a pr.

See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28585