Why string concatenation is used instead of doing it in JSX way? why? why?

gilbarbara / react-joyride

Create guided tours in your apps

https://react-joyride.com/

MIT License

6.75k stars 524 forks source link

Closed ppandatw closed 5 years ago

ppandatw commented 6 years ago

Apart from this line everything of 'locale' object can be a react node. Can you please use span or something for concatenation? Also update the type of 'locale's fields to React.Node from string. https://github.com/gilbarbara/react-joyride/blob/72fae22b81b73784efdf5c8ee85968b9ddac0454/src/components/Tooltip/Container.js#L33

gilbarbara commented 6 years ago

¯_(ツ)_/¯