search

gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.8k stars 525 forks source link

Controlled product tour popovers are not visible in React 18.1.0 using strict mode #811

Closed Aidensaid closed 2 years ago

Aidensaid commented 2 years ago

🐛 Bug Report

Product tour popovers are not visible in React 18.1.0 using strict mode.

To Reproduce

Steps to reproduce the behavior:

  1. Open the code sandbox

  2. Observe the product tour not visible

  3. Comment out React.StrictMode

  4. Observe the tour renders as expected

Expected behavior

Expect the tour popover to be visible in the UI.

Link to repl or repo (highly encouraged)

code sandbox

Run npx envinfo --system --binaries --npmPackages react-floater

Paste the results here:

 System:
    OS: macOS 11.6.1
    CPU: (8) x64 Apple M1
    Memory: 174.59 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 12.22.2 - ~/.nvm/versions/node/v12.22.2/bin/node
    npm: 6.14.13 - ~/.nvm/versions/node/v12.22.2/bin/npm
proyer-maxar commented 2 years ago

I'm experiencing the exact same issue! Thank you for beating me to the report.

nicvickeryw commented 2 years ago

Also experiencing this exact same issue

victorst79 commented 2 years ago

Same config, same issue here. :disappointed:

gilbarbara commented 2 years ago

hey guys,

Please use the reactions (emoji) in the first comment instead of replying with the "same here".

gilbarbara commented 2 years ago

Fixed in 2.5.0 Thanks

capucineSoum commented 2 years ago

Hello, I am still experiencing the issue with one step with the React Strict mode on. I have the 2.5.0 version of React Joyride.

Thank you

gilbarbara commented 2 years ago

Hey @capucineSoum

Update to the 2.5.1. If it still isn't working, create a new issue with a codesandbox.

capucineSoum commented 2 years ago

Hi @gilbarbara, I did the update and the issue is still there but it is not linked to the strict mode as I was thinking. I will continue looking for a solution.