gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.8k stars 525 forks source link

Only focus if scrolling is not disabled #818

Closed MikeShi42 closed 9 months ago

MikeShi42 commented 2 years ago

Fixes https://github.com/gilbarbara/react-joyride/issues/817

This changes so that the Scope does not auto-focus unless scrollToFirstStep is set to true and disableScrolling is not false. This may or may not be desirable behavior, but it wasn't clear to me what would be the right thing to do.

Additionally, changes husky pre-commit to find commands from the local node_modules bin folder, for some reason on my Mac it was not able to find lint-staged. Not sure if that's just a me issue or a general issue.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 932c9a8cf2366172f1cf323e09aedc5e76e883ab:

Sandbox Source
React Configuration
gilbarbara commented 9 months ago

Fixed in 2.7.2 Thanks