search

gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.64k stars 519 forks source link

Version of tree-changes #843

Closed hcjlxl closed 1 year ago

hcjlxl commented 1 year ago

🐛 Bug Report

react-joyride's version is 2.5.0. Error reported by using reactjoyride

To Reproduce

This error was given to me when I reinstalled the project dependency 20220905-194905 I found that there was a problem with the tree-changes upgrade in the recent update. This error will appear in tree-changes version 0.9.2，when I downgrade to version below 0.9.2, there will be no such error, for example, 0.9.1

gilbarbara commented 1 year ago

Hey @hcjlxl

Did you try to upgrade react-joyride to 2.5.2?

I've tried running the demo with 2.5.0 and tree-changes 0.9.2 without problems. What are you using to build your app? create-react-app, webpack, vite? Are your dependencies up-to-date?

I created this codesanbox, and it worked. Can you reproduce it in a codesandbox?

dxq2641249797 commented 1 year ago

Please create new app to try. I believe most people have this problem. At present, it is not convenient for me to use codesanbox. Thank you.

dxq2641249797 commented 1 year ago

And it is not about to build

hcjlxl commented 1 year ago

Hey @hcjlxl

Did you try to upgrade react-joyride to 2.5.2?

I've tried running the demo with 2.5.0 and tree-changes 0.9.2 without problems. What are you using to build your app? create-react-app, webpack, vite? Are your dependencies up-to-date?

I created this codesanbox, and it worked. Can you reproduce it in a codesandbox?

I use the project created by create-react-app. This error occurs in the create-react-app of 4.0.3. At the same time, you need to use the tree-changes version of 0.9.2. This is the sandbox link codesanbox

hcjlxl commented 1 year ago

I created this codesanbox，I edited the previous comment just now. I'm afraid you didn't notice. I added another one

ayusshar commented 1 year ago

Facing similar issue

deleted-user-account commented 1 year ago

https://github.com/gilbarbara/tree-changes/pull/24 - the version update is in the process of being reverted as per this PR

meanwhile we can set the resolution to older version in package.json "resolutions": { "tree-changes": "0.9.1" },

yarn - https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/

gilbarbara commented 1 year ago

I reverted the build changes in tree-changes@0.9.3 that could break legacy bundlers. If you still having this problem:

npm rm react-joyride
npm i react-joyride