gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.64k stars 519 forks source link

(Safari): Fullscreen of iframe in the ReactJoyride dialog issue #887

Closed dualisimo closed 1 year ago

dualisimo commented 1 year ago

🐛 Bug Report

When it is placed iframe (f.e. vimeo) within RJR dialog and this iframe has the fullscreen option, after opening video in the fullscreen mode it is not visible on the screen.

To Reproduce

  1. Place iframe with video and fullscreen option enabled to the RJR dialog.
  2. Open safari and play this video
  3. Open video in the fullscreen mode

Expected behavior

Usual view as in Chrome or FireFox.

gilbarbara commented 1 year ago

Hey @dualisimo

Please provide a codesandbox minimal reproducible link

dualisimo commented 1 year ago

Unfortunately, Code sandbox is blocking fullscreen option in the iframes. (╯°□°)╯︵ ┻━┻

gilbarbara commented 1 year ago

Try opening the preview in a new window. But I need some clarification. When the tooltip loads, would you like the video to render fullscreen, hiding the tooltip itself?

dualisimo commented 1 year ago

OMG, its shame, I didnt know about new window option. It works! Thank you.

Here is a code sandbox link and please:

  1. open it in Safari and in the new window mode.
  2. open RJR demo by clicking on Start button
  3. play video and open it in the full screen mode

you should see the issue then :)

Thanks

gilbarbara commented 1 year ago

The full screen is not working on Chrome/Firefox/Safari for that codesandbox. It display some errors about sandbox environment.

But anyway, this is something this library has no control and it doesn't have any specific code for browser vendors, so if the video isn't working in Safari, probably is a bug with the browser itself.

Good luck!

dualisimo commented 1 year ago

I can't agree. Full-screen video mode works on a safari within an iframe in all ways which I tried except RJR dialog. So for this bug is 100% responsible RJR package.

gilbarbara commented 1 year ago

Ok. Feel free to submit a PR. This library is open-source, after all.