gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.8k stars 525 forks source link

This bit of code does not adhere to the "disabledScroll" false flag: #913

Closed dweng0 closed 1 year ago

dweng0 commented 1 year ago

🐛 Bug Report

For the life of me, i was trying to work out how my parent container, (with overlfow auto set) was not scrolling, then i noticed this little nugget being injected into the element: image My code doesn't set that anywhere, so i did a search in the react-joyride code base and found it here

To Reproduce

Looking at the code, all you need to do is have a parent with scroll, the code

   parent.style.overflow = 'initial';

Will override it to its initial values

Expected behavior

The disableScroll flag in the joyride config should update this so it doesn't inject initial values, unless this is being done to prevent/fix another issue.

gilbarbara commented 1 year ago

Hey @dweng0

Please provide a https://codesandbox.io/ demo or similar. Issues without a reproduction link are likely to stall.