search

gilbarbara / react-joyride

Create guided tours in your apps
https://react-joyride.com/
MIT License
6.62k stars 519 forks source link

Placement for bottom-start does not re-position when scrolling #946

Open bfrable opened 9 months ago

bfrable commented 9 months ago

🐛 Bug Report

I've noticed when using bottom-start or top-start for placement, the tooltip does not auto re-position when scrolling according to the amount of the space within the element and the browser.

Bottom works as expected, left-start works as expected. All of the options seem to work except top-start and bottom-start.

To Reproduce

https://codesandbox.io/s/heuristic-chaum-kpd7kr?file=/src/Basic/index.tsx

The above codesandbox of your demo site shows that bottom-start does not auto re-position

To compare, react-floater sandbox demo site, bottom-start does work.

https://codesandbox.io/s/festive-grothendieck-gxk34v?file=/src/examples/WithStyledComponents.tsx:1198-1230

Expected behavior

'bottom-start' and 'top-start' re-position accordingly on scroll

Link to repl or repo (highly encouraged)

React Joyride Demo Site Example.

bfrable commented 9 months ago

This is resolved when using the latest version of floater.

klassm commented 5 months ago

With react-floater 0.9.3 more stuff seems to break. Is there a plan to release a new version of react-joyride including the latest version of react-floater? Thanks :-)

gilbarbara commented 5 months ago

Hey @klassm

With react-floater 0.9.3 more stuff seems to break. What does this mean?

And yes, I'll work on the upgrade when I have some time, but since it's a breaking change, it'll have to wait for some other upgrades.

klassm commented 5 months ago

We tried to just use react-floater 0.9.3 with the latest version of react-joyride. It compiles, but whenever you point to an item the beacon shows up, while it actually has been disabled. Not sure what else also breaks, we stopped looking there :-)