Closed sndrem closed 9 months ago
It looks as the Simplify
utility from type-fest
is different on my machine compared to the codesandbox example:
From my machine:
export type Simplify<
AnyType,
Options extends SimplifyOptions = {},
> = Flatten<AnyType> extends AnyType
? Flatten<AnyType, Options>
: AnyType;
Simplify in the codesandbox example
export type Simplify<T> = {[KeyType in keyof T]: T[KeyType]} & {};
It seems that this might have been a problem in our local setup which is a monorepo setup with Turborepo. There were other dependencies that had a dependency to type-fest
with an older version. We added an explicit version to type-fest
and now it works as intended.
We added an explicit version to type-fest and now it works as intended.
I don't believe that solves the problem. The types should work out of the box after installing joyride, without specifying extra dependencies manually. Either the types should be exported without the Simplify
util used, or the type-fest
dependency should be added as a regular dependency, not just a devDependency
in package.json
.
Fixed in v2.6.2 Thanks
🐛 Bug Report
After updating to version 2.6.0, the types for the Step seems to be broken.
To Reproduce
Update to version 2.6.0
Expected behavior
I would expect the type to have type information, not just the Any type.
Here is a link to a codesandbox that does work..., so this might not be a bug, but not sure why my editor says that the type is any... https://codesandbox.io/s/wonderful-hill-z2v55g?file=/src/index.ts
I have tried to nuke the node_modules-folder and reinstalled
react-joyride
with the latest version.Issues without a reproduction link are likely to stall.
Run
npx envinfo --system --binaries --npmPackages react-joyride
Paste the results here:
From my editor![image](https://github.com/gilbarbara/react-joyride/assets/9053627/7241ad3d-1d7b-49a4-b1b1-cf632c2bc734)
From codesandbox![image](https://github.com/gilbarbara/react-joyride/assets/9053627/0b913a97-8957-4258-a532-74262db4bbc1)