search

gilberthappi / To-Do-list

Other
0 stars 0 forks source link

Updated-Interactive-list #5

Closed gilberthappi closed 1 year ago

gilberthappi commented 1 year ago

Use webpack to bundle JavaScript. Learn how to use proper ES6 syntax. Use ES6 modules to write modular JavaScript.

medaminedev66 commented 1 year ago

Hi @gilberthappi,

This is a manual review

Request Changes ♻️

We apologize for the mistake made by the previous Code Reviewer, @usorfaitheloho. Your project is not complete, and the PR should not have been approved.

As per the requirements, the user should be able to clear all completed tasks. Please note that when the user clicks on the 'Clear all completed' button, all tasks with the 'completed' value set to true should be removed. Additionally, a function for the 'Clear all completed' button using the Array.filter() method should be implemented to achieve this.

Furthermore, users should have the capability to add and remove books to enhance the user experience. After the user clears all completed tasks, new tasks should be added to assess whether the app functions as expected.

Cheers and Happy coding!:clap::clap::clap:

enniopo commented 1 year ago

Hi @gilberthappi - I have changed the activity´s status on your dashboard so you can submit another code review request as soon as you are done implementing all the necessary changes. Once again, apologies for any inconvenience caused.

enniopo commented 1 year ago

Hi @gilberthappi - please disregard both my and @medaminedev66's comments. We saw you implemented the changes requested into another PR but then used this one to request the changes. That´s what caused the misunderstanding.

I have now approved your project again. No other actions are needed from your side.

gilberthappi commented 1 year ago

Okey Thanks Reset the activity´s status on my dashboard

On Fri, Aug 25, 2023 at 1:01 PM ennio @.***> wrote:

Hi @gilberthappi https://github.com/gilberthappi - please disregard both my and @medaminedev66 https://github.com/medaminedev66's comments. We saw you implemented the changes requested into another PR but then used this one to request the changes. That´s what caused the misunderstanding.

I have now approved your project again. No other actions are needed from your side.

— Reply to this email directly, view it on GitHub https://github.com/gilberthappi/To-Do-list/pull/5#issuecomment-1693181985, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2JN2NUQBGVTEICH5SFMLNLXXCAY5ANCNFSM6AAAAAA36DLJW4 . You are receiving this because you were mentioned.Message ID: @.***>