proposed fix for issue 117

gilbsgilbs / babel-plugin-i18next-extract

Babel plugin that statically extracts i18next and react-i18next translation keys.

https://i18next-extract.netlify.com

MIT License

161 stars 37 forks source link

Closed oaks-view closed 4 years ago

oaks-view commented 4 years ago

Fixes #117

oaks-view commented 4 years ago

@gilbsgilbs please any chance for a review soon?

gilbsgilbs commented 4 years ago

@oaks-view Yep yep yep, I have not forgotten, I'm just overwhelmed with work. I'll review ASAP, most likely this week-end. Sorry for the delay :cry:

gilbsgilbs commented 4 years ago

I iterated over your work to improve typings, semantics and tests. Could you check that it still works against your project?

oaks-view commented 4 years ago

@gilbsgilbs ive tested and it works against my project. Thanks

gilbsgilbs commented 4 years ago

Thanks

gilbsgilbs commented 4 years ago

I just released on NPM version 0.6.1 that includes this fix.