search

gilbsgilbs / babel-plugin-i18next-extract

Babel plugin that statically extracts i18next and react-i18next translation keys.
https://i18next-extract.netlify.com
MIT License
161 stars 37 forks source link

Config rework #129

Closed Robin-Hoodie closed 2 years ago

Robin-Hoodie commented 4 years ago

Also made me realize #128 is no longer needed should this be ready to be merged in.

If we want to hold off on merging this in for a while, #128 might be worth to be merged in for now however.

gilbsgilbs commented 4 years ago

Since this is a breaking change, I'll rather merge #128 and keep this PR open.

Robin-Hoodie commented 4 years ago

Since this is a breaking change, I'll rather merge #128 and keep this PR open.

So are there any changes you're requesting?

xDisfigure commented 4 years ago

Since this is a breaking change, I'll rather merge #128 and keep this PR open.

So are there any changes you're requesting?

Hello @Robin-Hoodie You can take a look to this feature request for the config : https://github.com/gilbsgilbs/babel-plugin-i18next-extract/pull/168

Robin-Hoodie commented 2 years ago

@xDisfigure Haven't looked at this in forever. Am I understanding things correctly that this PR is no longer necessary with the merge of #168 ?

Robin-Hoodie commented 2 years ago

@xDisfigure Let's close this PR if it's no longer relevant