search

gilbsgilbs / babel-plugin-i18next-extract

Babel plugin that statically extracts i18next and react-i18next translation keys.
https://i18next-extract.netlify.com
MIT License
161 stars 37 forks source link

Add customUseTranslationHooks configuration option #147

Closed dprgarner closed 4 years ago

dprgarner commented 4 years ago

Closes #146

This allows the plugin user to specify their own custom useTranslation hooks instead of just the react-i18next one. I've extended the code that was doing the same for custom <Trans> components, and used the same API as the customTransComponents option.

gilbsgilbs commented 4 years ago

After having a quick glance on the PR, it looks like a very qualitative work :medal_military: . Thank you. I'll try to give a more in depth review ASAP, but I think it will be fine.

Don't worry about the yarn audit CI failure, I'll update the dependencies in another PR. ~However, could you check what's wrong with node13 tests suite?~ Don't worry. Other branches seem also affected.

Thanks :tada:

gilbsgilbs commented 4 years ago

Nice work ! Thank you very much :pray: