gilch / hissp

It's Python with a Lissp.
https://gitter.im/hissp-lang/community
Apache License 2.0
369 stars 9 forks source link

Smarter reader macros #175

Closed gilch closed 1 year ago

gilch commented 1 year ago

Parts of #174.

Fully-qualified reader macros now don't require \# if looked up from _macro_, same as aliases. This also means you can't look up a non-reader macro and use as a fully-qualified reader macro. Would you ever want to do that? You can probably still inject those, but there may be edge cases involving unpicklable objects, which you could probably apply within the injected form as a normal invocation. If you can't, the workaround would be to assign a new name elsewhere.

Doesn't do extras for inject. I'm still considering that, but the implementation isn't trivial.

codecov[bot] commented 1 year ago

Codecov Report

Merging #175 (7ea2187) into master (e838808) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          691       696    +5     
  Branches       109       109           
=========================================
+ Hits           691       696    +5     
Impacted Files Coverage Δ
src/hissp/reader.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more