Closed gilch closed 1 year ago
gilch
commented
1 year ago Well, we got there pretty quickly. The warning seems to be in the test runner itself. Maybe I can tweak the config a bit, or ignore warnings just for that package. Might take a few experiments.
codecov[bot]
commented
1 year ago Merging #213 (0ee0f12) into master (6be47da) will decrease coverage by
0.29%. The diff coverage is100.00%.:exclamation: Current head 0ee0f12 differs from pull request most recent head f55da8d. Consider uploading reports for the commit f55da8d to get more accurate results
@@ Coverage Diff @@
## master #213 +/- ##
===========================================
- Coverage 100.00% 99.71% -0.29%
===========================================
Files 6 6
Lines 706 704 -2
Branches 111 110 -1
===========================================
- Hits 706 702 -4
- Misses 0 1 +1
- Partials 0 1 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/hissp/repl.py | 96.55% <ø> (-3.45%) |
:arrow_down: |
| src/hissp/reader.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
gilch
commented
1 year ago Wow, first try. I'm going to swap the order so I don't merge in failing commits.
gilch
commented
1 year ago Hmm. I maybe lost coverage on a one-line branch in the repl module. That may be dead code after removing that entry point. __main__ does that on its own. If you're calling it manually rather than via __main__, you should probably call hissp.repl.interact() instead.
I'll try removing the default for the __main__ argument to eliminate the branch.
Fixes #212.
Also configures warnings to fail the workflow, which would have caught this issue, which I confirmed in https://github.com/gilch/hissp/actions/runs/5086943652/jobs/9141865517.
Turns out deprecation warnings don't even print by default. This may turn out to be too strict, but we'll cross that bridge when we come to it.