search

gildas-lormeau / SingleFile

Web Extension for saving a faithful copy of a complete web page in a single HTML file
GNU Affero General Public License v3.0
15.33k stars 1k forks source link

Add an option to not set the sandbox attribute #1580

Open BloodlineL opened 1 week ago

BloodlineL commented 1 week ago

The sandbox attribute will report an error in the console. I hope that the file is completely static. If this poses a security risk, at least remove the sandbox attribute when both allow-scripts and allow-same-origin are set. In this case, the security is no different from not setting the sandbox attribute, and there will be no error in the console. 01 02

gildas-lormeau commented 1 week ago

Thank you, the sandbox warning(s) should be fixed in the next version. The error should not exist (Blocked script...). How can I reproduce it?

BloodlineL commented 1 week ago

The full error message is "Blocked script execution in 'about:srcdoc' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.", but I can't reproduce it now, maybe it's because I updated Chrome, or it's caused by other plugins, sorry for the trouble.