gildas-lormeau / SingleFile

Web Extension for saving a faithful copy of a complete web page in a single HTML file
GNU Affero General Public License v3.0
15.79k stars 1.02k forks source link

Setting `Site access > Allow this extension to read and change all your data on websites you visit` to `On click` breaks SingleFile (Chromium-based browsers) #894

Open keks24 opened 2 years ago

keks24 commented 2 years ago

Describe the bug Saved pages of stackoverflow.com are not formatted properly.

To Reproduce Steps to reproduce the behavior:

  1. Import the configuration file stackoverflow_profile_settings.json.txt
  2. Go to this StackOverflow page
  3. Right click the extension icon.
  4. Navigate to Save page with profile - stackoverflow.
  5. In the Save As prompt, click on Save.
  6. Open the saved HTML file.

Expected behavior The page layout should be the same as the original.

Screenshots It should look like this:

Original

![screencapture-stackoverflow-questions-37040798-how-do-you-use-youtube-dl-to-download-live-streams-that-are-live-2022-03-14-20_25_19](https://user-images.githubusercontent.com/13721064/158247051-6bf79b62-b355-45eb-b04e-26c127d63c0a.png)

https://stackoverflow.com/questions/37040798/how-do-you-use-youtube-dl-to-download-live-streams-that-are-live

But it looks like this:

Saved with SingleFile

![screencapture-file-home-ramon-downloads-d88babf2-7e11-4427-a441-247d2126f784-html-2022-03-14-20_33_09](https://user-images.githubusercontent.com/13721064/158247449-dc89fa26-d37a-4b75-80b9-c023d1a88879.png)

d88babf2-7e11-4427-a441-247d2126f784.html.txt

Environment

Additional context None.

gildas-lormeau commented 2 years ago

Thank you for the detailed report. Unfortunately, I was not able to reproduce the issue by following the procedure you described. On my end, all the resources are properly included in the page. I did my tests on Windows 10 Pro (64-bit) with Chrome 99.0.4844.51 and the version 1.19.34 of SingleFile. However, I suspect your issue is related to the fact that the setting "Site access > Allow this extension to read and change all your data on websites you visit" would not be set to "On all sites" here: chrome://extensions/?id=mpiodijhokgodhhofbcjdecpffjipkle`. It seems this feature is somewhat broken.

keks24 commented 2 years ago

Thanks for the quick reply!

Indeed, changing the extension setting Allow this extension to read and change all your data on websites that you visit: to On all sites fixes the issue.

Using the option On click or On specific sites with *://stackoverflow.com/* breaks the layout like above.