search

gildas-lormeau / SingleFile

Web Extension for saving a faithful copy of a complete web page in a single HTML file
GNU Affero General Public License v3.0
15.49k stars 1.01k forks source link

Two bugreports #97

Closed AliM1988 closed 5 years ago

AliM1988 commented 5 years ago

Hi I faced two issues in this RUL: https://talachart.ir/4-types-of-gaps-in-the-market/

1) The images do not included in saved page. 2) To see the top header and the left bar, we must scroll up at first, then click save. Othervise (for example, if you scroll down to the middle of page) those bar is disappeared or incompleted.

OS: Win 8 Browser: Chrome v70.0.3538.102 (Official Build) (64-bit) Tested browser for saved HTML file: Chrome , Firefox, IE

Thanks in advance Regard

gildas-lormeau commented 5 years ago

Hi,

Thanks for reporting the issues.

  1. I cannot reproduce it. I did the test on Win 10 Pro, Chrome 70.0.3538.102 (Official Build) (64-bit) and 70.0.3538.110 (Official Build) (64-bit). This file آشنایی با ۴ نوع از گپ_های بازار - طلاچارت (2018-11-20 12_26_27 AM).zip is the saved page. I doubt the OS or the version of Chrome are really involved. Did you change any option? Can you try to disable all other extensions to see if this fixes the issue?
  2. It's a common issue on websites where the header resizes itself when scrolling down. I think I can implement something to circumvent this by faking a scroll to the top of the page. It will require a new option though because it will be based on a hack.
AliM1988 commented 5 years ago

Hi Thank you for checking. About the file you sent, I did some tests:

note1: I want to use the extension to archive many webpages and I want these open correctly in the all versions of all browsers (Like native method of saving file+folder)

note2: I checked some pages of the mentioned URL has not this problem. for example: https://talachart.ir/candlestick-patterns-part-1/

Regard

gildas-lormeau commented 5 years ago

Hi,

The issue you described is fixed in the version 1.8.65. Actually, this issue is also related to the option "group duplicate images together". This option detects repeated images in the page and apply a transform in the page in order to store them one time only. There are 2 cons. This transform is compatible with modern browsers only, and the repeated image cannot be saved as easily as a normal image with the context menu. Most of the time, this feature concerns ads, avatars or minor graphical elements so it's not really an issue. If you think this could be an issue for you then I recommend to uncheck the option "group duplicate images together". This will also solve the incompatibilities with old browsers.

AliM1988 commented 5 years ago

In the mentioned URL unchecking option "group duplicate images together" cause a huge file size and the result file is not same as the main webpage. However, The issue (no. 1) is solved in v1.8.65 completely and the result file works fine with other browsers. Thank you very much!

Regard

gildas-lormeau commented 5 years ago

You're welcome. I confirm it can produce bigger files sometimes but not for the URLs mentioned. On my end I get files weighting respectively 1MB and 1.7MB for the 2 URLs. Make sure "remove images for alternative screen resolutions" is checked.

AliM1988 commented 5 years ago

I found some other minor bugs. These don't bother me, but I report them for improvement in future and expressing my gratitude:

Test URL: https://talachart.ir/4-types-of-gaps-in-the-market/ Browser to create saved file: Chrome v70.0.3538.102 (Official Build) (64-bit) Browsers to view saved file: Chrome v70, Opera v56, Firefox v30 & IE v10

The issues:

Regard

gildas-lormeau commented 5 years ago

Thank you for your gratitude. Regarding the issues, here are my answers:

By the way, I have a question. Would you prefer the infobar to be located on the left?

AliM1988 commented 5 years ago

About location of infobar, I prefer it be the right but in auto-hide form (If it is possible). Othervise, it's better smaller.

I have a suggestion: If it possible, users can switch among multiple settings (like profile or ....)

AliM1988 commented 5 years ago

Hi,

The issue you described is fixed in the version 1.8.65. Actually, this issue is also related to the option "group duplicate images together". This option detects repeated images in the page and apply a transform in the page in order to store them one time only. There are 2 cons. This transform is compatible with modern browsers only, and the repeated image cannot be saved as easily as a normal image with the context menu. Most of the time, this feature concerns ads, avatars or minor graphical elements so it's not really an issue. If you think this could be an issue for you then I recommend to uncheck the option "group duplicate images together". This will also solve the incompatibilities with old browsers.

Hi again I faced same issue in 2 below URL. I think it's concern to SVG+XML image type.

Regard

gildas-lormeau commented 5 years ago

The JavaScript issue is fixed, see https://github.com/gildas-lormeau/SingleFile/issues/98.

gildas-lormeau commented 5 years ago

The last issue you described is a feature. I already explained the pros and cons here. Please unckeck "group duplicate images together".

gildas-lormeau commented 5 years ago

I'm not able to reproduce the issue related to invalid characters. On my end, if I set "test/{page-title} ({date-iso} {time-locale}).html" as template, I don't see any "_" for the characters you mentioned in the filename. Please file a separated new issue describing more precisely how to reproduce it.

gildas-lormeau commented 5 years ago

To display the infobar on Firefox, install the extension first. The infobar will be displayed only when the extension is installed.

gildas-lormeau commented 5 years ago

Please file a bug describing what kind of behavior you would like to see for the infobar. My question was more about the fact that you write from right to left. I was wondering if it would make more sense to display it in the left part of the page. It looks like this is not the case. If I'm wrong, please file a separated issue.

gildas-lormeau commented 5 years ago

I'm closing this issue because it's too messy. Feel free to create new ones for each issues, as suggested in my previous responses.

gildas-lormeau commented 5 years ago

@AliM1988 I just saw your comment on ghacks and I remembered I fixed recently the issue "If you change some options of extension, you must refresh already loaded webpage at first, then click the button to make HTML file.". You were right, this issue was existing when enabling features.

By the way, note that you can now easily change the current profile/settings with the sidebar.