webDAV saving: zip.html and letter after sharp will be discard when title included "#"

gildas-lormeau / SingleFileZ

Web Extension to save a faithful copy of an entire web page in a self-extracting ZIP file

GNU Affero General Public License v3.0

1.82k stars 140 forks source link

webDAV saving: zip.html and letter after sharp will be discard when title included "#" #139

Closed ms300 closed 1 year ago

ms300 commented 2 years ago

saving the page with sharp included in the title such as https://www.google.com.hk/search?q=2%233 or this issue page to webDAV will cause the letter after the sharp discarded.

expected filename: 2#3 - Google Search.zip.html actual filename: 2

It is probably because sharp is a special character for URL: https://en.wikipedia.org/wiki/URI_fragment, the filename should be encoded when passing to webDAV server.

gildas-lormeau commented 1 year ago

If I'm not wrong, this issue should be fixed.

ms300 commented 1 year ago

Thanks!