search

gildas-lormeau / SingleFileZ

Web Extension to save a faithful copy of an entire web page in a self-extracting ZIP file
GNU Affero General Public License v3.0
1.82k stars 140 forks source link

Crash on Waterfox loading saved page with large gifs #172

Closed robbely closed 5 months ago

robbely commented 10 months ago

If I use SingleFilesZ to save the page from "https://store.steampowered.com/app/1722660/Hamster_on_Rails/" as an example with large gifs, the file appears to save correctly. However if I reload into Waterfox (latest: G6.0.5 based on latest Firefox ESR) I get the Gah Tab Crashed error. (The saved page loads successfully however in the equivalent Firefox ESR release).

I've tried with clean install of Waterfox and not changing any SingleFileZ settings.

If I open the saved page in winrar and delete the 3 large gifs from the images folder the page will then load successfully in Waterfox.

gildas-lormeau commented 10 months ago

I must confess that I don't know how I can help you. The file is decompressed before being displayed. As a result, memory consumption is impacted during this stage.

I suppose that with SingleFile, this might not be a problem. FYI, I have merged SingleFileZ into SingleFile. The "File format" section in the options page lets you choose the output format.

robbely commented 10 months ago

I must confess that I don't know how I can help you. The file is decompressed before being displayed. As a result, memory consumption is impacted during this stage.

Memory consumption was my thought too, it's odd that it only happens in the one variant of firefox (I've tried on tor browser too - again the same esr version and that one loads the saved page ok too).

Do you know if there are any about:config settings that might allow more memory in a tab before the tab gives up and crashes?

gildas-lormeau commented 10 months ago

I added quite recently a new feature that allows SFZ pages to be opened in any browser without having to install the extension (like SF). It's enabled by default. Maybe disabling it could fix this issue, cf. ZIP content > add metadata to extract data from the page option.

robbely commented 10 months ago

I added quite recently a new feature that allows SFZ pages to be opened in any browser without having to install the extension (like SF). It's enabled by default. Maybe disabling it could fix this issue, cf. ZIP content > add metadata to extract data from the page option.

Unfortunately I still get the crashes disabling this. Did you have any ideas the the about:config setting?

EDIT: I was about to open an issue in the Waterfox github page, but it looks like someone else is having the same issue there https://github.com/WaterfoxCo/Waterfox/issues/3254

gildas-lormeau commented 10 months ago

I confirm that I don't know how to circumvent this issue with about:config, unfortunately. BTW, if it's a regression in Waterfox, maybe you should specify it in the issue of Waterfox.

robbely commented 10 months ago

BTW, if it's a regression in Waterfox, maybe you should specify it in the issue of Waterfox.

Unfortunately this is the first version of Waterfox I have tried the extension in, so cannot determine if it is a regression or just a difference in setup for Waterfox.

robbely commented 5 months ago

Seems fixed in G6.0.10