search

gildas-lormeau / SingleFileZ

Web Extension to save a faithful copy of an entire web page in a self-extracting ZIP file
GNU Affero General Public License v3.0
1.82k stars 140 forks source link

"View Image" and "Save Image As..." don't work as they probably should #90

Closed lkintact closed 3 years ago

lkintact commented 3 years ago

(This has some relation to gildas-lormeau/SingleFile#645).

To Reproduce

  1. Create a new Firefox profile, add SingleFileZ to it (don't enable "Allow this extension to run in Private Windows" when adding SFZ).
  2. Save the page at http://www.photographers1.com/Sailing/NauticalTerms&Nomenclature.html with SFZ, open the saved file.
  3. Search for DANGER ZONE !!! in the page, one match will be found with an image below: a white ship hull in a circle with black sector, titled "Bearings of Objects in Relation to Your Vessel".
  4. Right-click on the image and click on "View Image". A dialogue like this pops up:

capture

  1. Right-click on the image and click on "Save Image As...". A "Save Image" dialogue pops up with the prefilled filename index.gif.

Expected behavior The image should perhaps be shown in the current browser tab at step 4. The prefilled filename should be Bearings.gif at step 5.

Environment

gildas-lormeau commented 3 years ago

That looks indeed a bug since the extension of the URL was ".gif", I'll try to see what's wrong this weekend.

gildas-lormeau commented 3 years ago

This issue is fixed in the version 1.0.19.

Edit: I mean that the "View image" bug is fixed. The filename issue cannot be fixed. The URL of the image resource can be found in the index.json file in the zip. Each entry in the zip file has also as comment the URL of the resource.

lkintact commented 3 years ago

Just tried version 1.0.19, "View image" works for me, too.

The URL of the image resource can be found in the index.json file in the zip. Each entry in the zip file has also as comment the URL of the resource.

Thanks for letting know!