gildas-lormeau / single-file-cli

CLI tool for saving a faithful copy of a complete web page in a single HTML file (based on SingleFile)
GNU Affero General Public License v3.0
540 stars 58 forks source link

single-file-cli hangs even on `domcontentloaded` #43

Open alex2awesome opened 1 year ago

alex2awesome commented 1 year ago

Hello! I love single-file and single-file-cli. Truly the best option out there for saving full and complete webpages!

Right now, it's hitting this strange problem where, as far as I can tell, the page hangs indefinitely, even under the lowest load settings.

It might be related to this? https://github.com/puppeteer/puppeteer/issues/9196 Not entirely sure.

To Reproduce Run the following command in bash:

single-file --browser-executable-path=/opt/homebrew/bin/chromium https://web.archive.org/web/20140325112710/http://www.sfchronicle.com/ --block-images --dump-content --browser-headless false --browser-wait-until domcontentloaded --browser-debug

Environment

alex2awesome commented 1 year ago

My apologies... should have posted in https://github.com/gildas-lormeau/single-file-cli

I could not get it to work with playwright-chrome or playwright-firefox either.

However, if I manage playwright on my own and then integrate singleFile as in: https://github.com/gildas-lormeau/SingleFile/wiki/How-to-execute-a-user-script-before-a-page-is-saved, it does work

gildas-lormeau commented 11 months ago

Sorry for the very late reply, I confirm the issue you're describing is something I've already seen in the past. AFAIK, it's not related to the implementation of the single-file-cli.

I'm also transferring the issue ;)