gildas-lormeau / single-file-cli

CLI tool for saving a faithful copy of a complete web page in a single HTML file (based on SingleFile)
GNU Affero General Public License v3.0
539 stars 57 forks source link

Images don't get downloaded using CLI #51

Closed DeployThemAll closed 2 months ago

DeployThemAll commented 10 months ago

For questions, please create or update a thread here: https://github.com/gildas-lormeau/SingleFile/discussions

Please ensure that you do not find an answer before reporting the issue:

Describe the bug I'm trying to automate singlefile with my small project for downloading a webpage exactly like I can do manually from the extension bar.

However, when using the cli with nodejs, I found out that the downloaded webpage doesn't have images, specifically the one that is hosted on amazonaws.

I manually managed to download succesfully the page with the extension but when using the CLI, I can't download everything in the page.

To Reproduce Steps to reproduce the behavior: You can try with the page for example to see what I'm talking about https://www.tigergroup.ae/

The images hosted on amazonaws can't be downloaded but the image of the popup is hosted on their server, so it was downloaded

I tried using the extension and it worked fine.

Expected behavior a good html file should be downloaded will all resources embeded specially images

Environment

gildas-lormeau commented 10 months ago

I was not able to reproduce the issue with the default settings. The saved page is in the attached zip file. The only difference is that I did the test on macOS but I doubt the OS would change anything on my end. Do you pass any option to single-file-cli when running it?

Tiger Group _ Home (2023-08-16 11_35_16 PM).html.zip